ci: remove unnecessary ${{ }} from if conditions

Signed-off-by: Ahmed Al-Nassif <mr.ahmed.nassif@gmail.com>

.github/actions/apply-device-patches/action.yml

@@ -12,7 +12,7 @@ runs:
   using: "composite"
   steps:
     - name: Fix WiFi and Bluetooth on Samsung 6.6 GKI Devices
-      if: ${{ inputs.version == 'android15-6.6' }}
+      if: inputs.version == 'android15-6.6'
       shell: bash
       working-directory: ${{ github.workspace }}/kernel/common
       run: |
@@ -30,7 +30,7 @@ runs:
         echo "obj-y += min_kdp.o" >> drivers/Makefile
 
     - name: Fix WiFi and Bluetooth on Xiaomi 6.6 GKI Devices
-      if: ${{ inputs.version == 'android15-6.6' }}
+      if: inputs.version == 'android15-6.6'
       shell: bash
       working-directory: ${{ github.workspace }}/kernel/common
       run: |

.github/actions/btf/action.yml

@@ -17,7 +17,7 @@ runs:
     - name: Apply libbpf feature-detection fix (android12-5.10)
       shell: bash
       working-directory: ${{ github.workspace }}/kernel/common
-      if: ${{ inputs.version == 'android12-5.10' }}
+      if: inputs.version == 'android12-5.10'
       run: |
         set -euo pipefail
         patch -p1 -N < ${{ github.action_path }}/patches/0001-libbpf-remove-feature-detection-BTF.patch
@@ -25,7 +25,7 @@ runs:
     - name: Apply resolve_btfids linker-flag fix (android12-5.10)
       shell: bash
       working-directory: ${{ github.workspace }}/kernel/common
-      if: ${{ inputs.version == 'android12-5.10' }}
+      if: inputs.version == 'android12-5.10'
       run: |
         set -euo pipefail
         patch -p1 -N < ${{ github.action_path }}/patches/0002-resolve_btfids-inherit-host-linker-flags.patch
@@ -33,7 +33,7 @@ runs:
     - name: Apply ANDROID_KABI_USE macro fix (android12-5.10, sublevel 43)
       shell: bash
       working-directory: ${{ github.workspace }}/kernel/common
-      if: ${{ inputs.version == 'android12-5.10' && inputs.sublevel == '43' }}
+      if: inputs.version == 'android12-5.10' && inputs.sublevel == '43'
       run: |
         set -euo pipefail
         # Rework ANDROID_KABI_USE() to drop __UNIQUE_ID(android_kabi_hide).
@@ -46,7 +46,7 @@ runs:
     # - name: Apply xdp_buff BTF-emit fix (android12-5.10)
     #   shell: bash
     #   working-directory: ${{ github.workspace }}/kernel/common
-    #   if: ${{ inputs.version == 'android12-5.10' }}
+    #   if: inputs.version == 'android12-5.10'
     #   run: |
     #     set -euo pipefail
     #     # bpf_types.h references struct xdp_buff via
@@ -64,7 +64,7 @@ runs:
     # - name: Apply resolve_btfids ELF_T_WORD endian fix (android12-5.10)
     #   shell: bash
     #   working-directory: ${{ github.workspace }}/kernel/common
-    #   if: ${{ inputs.version == 'android12-5.10' }}
+    #   if: inputs.version == 'android12-5.10'
     #   run: |
     #     set -euo pipefail
     #     # Backport of upstream 61e8aeda9398 ("bpf: Fix libelf endian handling
@@ -85,7 +85,7 @@ runs:
     - name: Expose host dd for hermetic BTF generation (android12-5.10)
       shell: bash
       working-directory: ${{ github.workspace }}/kernel/common
-      if: ${{ inputs.version == 'android12-5.10' }}
+      if: inputs.version == 'android12-5.10'
       run: |
         set -euo pipefail
         # The hermetic toolchain PATH (build.config.common -> HERMETIC_TOOLCHAIN=1)
@@ -101,7 +101,7 @@ runs:
     - name: Build and use pahole >=1.26 for hermetic BTF generation (android12-5.10)
       shell: bash
       working-directory: ${{ github.workspace }}/kernel
-      if: ${{ inputs.version == 'android12-5.10' }}
+      if: inputs.version == 'android12-5.10'
       run: |
         set -euo pipefail
         # android12-5.10 pins prebuilt pahole v1.19, which fails to recode the

.github/actions/build-kernel/action.yml

@@ -74,7 +74,7 @@ runs:
 
   - name: 'Patch AnyKernel3 for Bypass Hack'
     shell: bash
-    if: ${{ inputs.bypass == 'true' }}
+    if: inputs.bypass == 'true'
     working-directory: ${{ github.workspace }}/AnyKernel3
     run: |
       set -euo pipefail

.github/actions/kernel-fixes/action.yml

@@ -60,7 +60,7 @@ runs:
 
     - name: 'Apply mmap.c fix for specific versions'
       shell: bash
-      if: ${{ inputs.version == 'android15-6.6' && inputs.sublevel <= '58' }}
+      if: inputs.version == 'android15-6.6' && inputs.sublevel <= '58'
       working-directory: ${{ github.workspace }}/kernel/common
       run: |
         echo "[*] Checking for android15 + kernel 6.6 include fix..."
@@ -79,7 +79,7 @@ runs:
 
     - name: 'Apply mmap.c fix for specific versions'
       shell: bash
-      if: ${{ (inputs.version == 'android12-5.10' && inputs.sublevel == 226) || (inputs.version == 'android13-5.10' && inputs.sublevel == 223) || (inputs.version == 'android13-5.15' && inputs.sublevel == 167) || (inputs.version == 'android14-5.15' && inputs.sublevel == 167) }}
+      if: (inputs.version == 'android12-5.10' && inputs.sublevel == 226) || (inputs.version == 'android13-5.10' && inputs.sublevel == 223) || (inputs.version == 'android13-5.15' && inputs.sublevel == 167) || (inputs.version == 'android14-5.15' && inputs.sublevel == 167)
       working-directory: ${{ github.workspace }}/kernel/common
       run: |
         echo "[*] Applying mmap.c fix for specific version combo."

.github/actions/setup-build-environment/action.yml

@@ -62,7 +62,7 @@ runs:
 
     - name: Install build deps for BTF generation (android12-5.10)
       shell: bash
-      if: ${{ inputs.version == 'android12-5.10' }}
+      if: inputs.version == 'android12-5.10'
       run: |
         set -euo pipefail
         sudo apt-get update -qq

.github/actions/susfs-config/action.yml

@@ -24,14 +24,14 @@ runs:
           CONFIG_KSU_SUSFS_SUS_MAP=y
 
     - name: Enable SUSFS Open Redirect (no NoMount)
-      if: ${{ inputs.nomount_enabled != 'true' }}
+      if: inputs.nomount_enabled != 'true'
       uses: ./.github/actions/set-kernel-config
       with:
         config_list: |
           CONFIG_KSU_SUSFS_OPEN_REDIRECT=y
 
     - name: Disable SUSFS Open Redirect (NoMount integrated)
-      if: ${{ inputs.nomount_enabled == 'true' }}
+      if: inputs.nomount_enabled == 'true'
       uses: ./.github/actions/set-kernel-config
       with:
         config_list: |

.github/workflows/build.yml

@@ -168,14 +168,14 @@ jobs:
         os_patch_level: ${{ inputs.os_patch_level }}
 
     - name: Setup Selected Root Implementation
-      if: ${{ inputs.root_flavor != '' }}
+      if: inputs.root_flavor != ''
       uses: ./.github/actions/root-setup
       with:
         flavor: ${{ inputs.root_flavor }}
         commit: ${{ inputs.root_commit }}
 
     - name: Disable SUSFS for ReSukiSU without SUSFS feature
-      if: ${{ inputs.root_flavor == 'resukisu' && !contains(inputs.feature_set, 'SUSFS') }}
+      if: inputs.root_flavor == 'resukisu' && !contains(inputs.feature_set, 'SUSFS')
       uses: ./.github/actions/set-kernel-config
       with:
         config_list: |
@@ -323,7 +323,7 @@ jobs:
         kernel_version: ${{ inputs.kernel_version }}
 
     - name: Integrate NoMount
-      if: ${{ inputs.nomount_commit != '' || contains(inputs.feature_set, 'NoMount') || inputs.feature_set == 'All' }}
+      if: inputs.nomount_commit != '' || contains(inputs.feature_set, 'NoMount') || inputs.feature_set == 'All'
       uses: ./.github/actions/nomount
       with:
         commit: ${{ inputs.nomount_commit }}
@@ -367,11 +367,11 @@ jobs:
 
     - name: Scan and collect patch rejects
       id: scan
-      if: ${{ always() }}
+      if: always()
       uses: ./.github/actions/scan-patch-rejects
         
     - name: Upload Rejects
-      if: ${{ always() }}
+      if: always()
       uses: actions/upload-artifact@v7
       with:
         name: ${{ steps.extract.outputs.file_name }}-Rejects
@@ -501,7 +501,7 @@ jobs:
         github_token: ${{ github.token }}
 
     - name: Build Bypass Kernel
-      if: false
+      if: inputs.build_bypass
       env:
         SOURCE_DATE_EPOCH: ${{ env.SOURCE_DATE_EPOCH }}
         KBUILD_BUILD_TIMESTAMP: ${{ env.KBUILD_BUILD_TIMESTAMP }}
@@ -511,7 +511,7 @@ jobs:
         version: ${{ inputs.version }}
 
     - name: Consolidated Build Summary
-      if: ${{ always() }}
+      if: always()
       shell: bash
       run: |
         SUMMARY_BASE="${{ steps.extract.outputs.file_name }}"
@@ -606,7 +606,7 @@ jobs:
         compression-level: 9
 
     - name: Write Build-verified only artifact metadata
-      if: ${{ success() && inputs.root_flavor != '' && inputs.nomount_commit != '' }}
+      if: success() && inputs.root_flavor != '' && inputs.nomount_commit != ''
       shell: bash
       env:
         GH_TOKEN: ${{ github.token }}

.github/workflows/main.yml

@@ -428,7 +428,7 @@ jobs:
           echo "feature_set=${FEATURES%+}" >> "$GITHUB_OUTPUT"
 
       - name: Clone shared source repos once
-        if: ${{ inputs.use_nomount }}
+        if: inputs.use_nomount
         shell: bash
         run: |
           set -euo pipefail
@@ -443,7 +443,7 @@ jobs:
 
   list-manager-apks:
     needs: resolve-sources
-    if: ${{ needs.resolve-sources.outputs.manager_list != '' }}
+    if: needs.resolve-sources.outputs.manager_list != ''
     runs-on: ubuntu-latest
     outputs:
       apk_list: ${{ steps.scan.outputs.apk_list }}
@@ -539,7 +539,7 @@ jobs:
 
   publish-manager-artifacts:
     needs: list-manager-apks
-    if: ${{ needs.list-manager-apks.outputs.apk_list != '' }}
+    if: needs.list-manager-apks.outputs.apk_list != ''
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -567,11 +567,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v7
-        if: ${{ inputs.use_nomount }}
+        if: inputs.use_nomount
 
       - name: Clone NoMount source at pinned commit
         id: clone
-        if: ${{ inputs.use_nomount }}
+        if: inputs.use_nomount
         shell: bash
         run: |
           set -euo pipefail
@@ -584,14 +584,14 @@ jobs:
           echo "commit=${COMMIT}" >> "$GITHUB_OUTPUT"
 
       - name: Build NoMount metamodule (nm only, no .ko)
-        if: ${{ inputs.use_nomount }}
+        if: inputs.use_nomount
         id: buildmod
         uses: ./.github/actions/nomount-metamodule
         with:
           commit: ${{ steps.clone.outputs.commit }}
 
       - name: Upload NoMount metamodule
-        if: ${{ inputs.use_nomount }}
+        if: inputs.use_nomount
         uses: actions/upload-artifact@v7
         with:
           name: NoMount-Metamodule
@@ -605,7 +605,7 @@ jobs:
     - resolve-sources
     - build-nomount-module
     - publish-manager-artifacts
-    if: ${{ !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android12-5.10') }}
+    if: !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android12-5.10')
     strategy:
       fail-fast: false
       matrix:
@@ -634,7 +634,7 @@ jobs:
     - resolve-sources
     - build-nomount-module
     - publish-manager-artifacts
-    if: ${{ !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android13-5.10') }}
+    if: !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android13-5.10')
     strategy:
       fail-fast: false
       matrix:
@@ -663,7 +663,7 @@ jobs:
     - resolve-sources
     - build-nomount-module
     - publish-manager-artifacts
-    if: ${{ !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android13-5.15') }}
+    if: !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android13-5.15')
     strategy:
       fail-fast: false
       matrix:
@@ -692,7 +692,7 @@ jobs:
     - resolve-sources
     - build-nomount-module
     - publish-manager-artifacts
-    if: ${{ !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android14-5.15') }}
+    if: !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android14-5.15')
     strategy:
       fail-fast: false
       matrix:
@@ -721,7 +721,7 @@ jobs:
     - resolve-sources
     - build-nomount-module
     - publish-manager-artifacts
-    if: ${{ !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android14-6.1') }}
+    if: !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android14-6.1')
     strategy:
       fail-fast: false
       matrix:
@@ -750,7 +750,7 @@ jobs:
     - resolve-sources
     - build-nomount-module
     - publish-manager-artifacts
-    if: ${{ !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android15-6.6') }}
+    if: !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android15-6.6')
     strategy:
       fail-fast: false
       matrix:
@@ -779,7 +779,7 @@ jobs:
     - resolve-sources
     - build-nomount-module
     - publish-manager-artifacts
-    if: ${{ !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android16-6.12') }}
+    if: !inputs.test_release_notes && (inputs.kernel_build_version == 'All' || inputs.kernel_build_version == 'android16-6.12')
     strategy:
       fail-fast: false
       matrix:
@@ -803,7 +803,7 @@ jobs:
     secrets: inherit
 
   update-verified-pins:
-    if: ${{ !inputs.test_release_notes && inputs.commit_mode == 'update' }}
+    if: !inputs.test_release_notes && inputs.commit_mode == 'update'
     runs-on: ubuntu-latest
     permissions:
       actions: read
@@ -839,7 +839,7 @@ jobs:
         APPROVE_RESUKISU: ${{ (inputs.root_flavor == 'ReSukiSU' || inputs.root_flavor == 'All') }}
 
     - name: Commit promoted pins
-      if: ${{ always() && steps.promote.conclusion == 'success' }}
+      if: always() && steps.promote.conclusion == 'success'
       shell: bash
       run: |
         set -euo pipefail
@@ -854,7 +854,7 @@ jobs:
         git commit -m "chore(pins): promote verified commits to latest built (${STAMP})"
         git push
   rej:
-    if: ${{ !inputs.test_release_notes && always() }}
+    if: !inputs.test_release_notes && always()
     runs-on: ubuntu-latest
     permissions:
       actions: read